search

timbunce / devel-nytprof

Devel::NYTProf is a powerful feature-rich source code profiler for Perl. (Mostly in maintenance mode, so PRs are much more likely to be acted upon than Issues.)
http://blog.timbunce.org/tag/nytprof/
67 stars 51 forks source link

Migrated to Github Actions, #201 #207

Open hurricup opened 1 year ago

hurricup commented 1 year ago

Testing on linux/mac/windows with all numeric versions

There is an issue with non-trivial versions, see shogo82148/actions-setup-perl#1444

hurricup commented 1 year ago

Probably I also need to change badge

jkeenan commented 1 year ago

Testing on linux/mac/windows with all numeric versions

There is an issue with non-trivial versions, see shogo82148/actions-setup-perl#1444

While I agree that the travis-ci configuration is outmoded and should be deleted, I myself have never GitHub actions in the CPAN distros I've authored or maintained. Nor have I used cpanfile in this context.

Can you provide examples of other CPAN distributions maintained on GH which use these tools?

hurricup commented 1 year ago

For example:

I couldn't find the way to install dependencies from the Makefile.PL, so I created this cpanfile. The other way was to pull travis helpers and use them, but this feels like overkill.

I'm confused a bit with your question. Why not use a nice widely-used tool even if noone using it in the perl/cpan community?

shawnlaffan commented 1 year ago

This looks good to me.

It would be useful to add a few Strawberry perl instances as well. They are covered by the appveyor config but appveyor builds seem not to be triggered since the config was renamed in 33c24caec72d9b88bedbe1081ee66a9df621745e ?

Edit - but Strawberry perl should not stop this PR being merged.

jkeenan commented 1 year ago

On 3/6/23 16:00, shawnlaffan wrote:

This looks good to me.

It would be useful to add a few Strawberry perl instances as well. They are covered by the appveyor config but appveyor builds seem not to be triggered since the config was renamed in 33c24ca https://github.com/timbunce/devel-nytprof/commit/33c24caec72d9b88bedbe1081ee66a9df621745e ?

@shawnlaffan, could you file a separate GH issue about Appveyor? I note that I see Appveyor builds at:

https://ci.appveyor.com/project/jkeenan/devel-nytprof

I ran a build just now.

Thanks. jimk

shawnlaffan commented 1 year ago

@shawnlaffan, could you file a separate GH issue about Appveyor? I note that I see Appveyor builds at: https://ci.appveyor.com/project/jkeenan/devel-nytprof I ran a build just now.

Ah. The appveyor builds are on the jkeenan fork, hence will not show up on this repo. I'll file an issue.

hurricup commented 1 year ago

action supports strawberry distros as well. https://github.com/shogo82148/actions-setup-perl#use-strawberry-perl-on-windows

we may just replace pre-cooked windows perls with strawberry