search

timbunce / devel-nytprof

Devel::NYTProf is a powerful feature-rich source code profiler for Perl. (Mostly in maintenance mode, so PRs are much more likely to be acted upon than Issues.)
http://blog.timbunce.org/tag/nytprof/
67 stars 50 forks source link

Silence build-time warnings when using recent clang #216

Closed jkeenan closed 9 months ago

jkeenan commented 9 months ago

In this pull request, the only thing which a reviewer should be concerned about is the first commit, c1e2620839aaa74c6e9273bb687f7939d8267a2e, which consists solely of changes to ppport.h. The other two commits are housekeeping which I will take care of.

khwilliamson commented 9 months ago

I don't understand this. When a module is released, it is supposed to copy the latest ppport.h., not patch an old version. The one in blead is the most correct now.

jkeenan commented 9 months ago

I don't understand this. When a module is released, it is supposed to copy the latest ppport.h., not patch an old version. The one in blead is the most correct now.

Well, that shows you how little I know about PPPort!

Please review https://github.com/timbunce/devel-nytprof/pull/216/commits/7f872cbf739735ce6ec242c174f5d2c89c8d5d3c, the most recent commit in this p.r. The commit message will tell you what steps I took to generate the code. Thanks.

jkeenan commented 9 months ago

Thanks for the review. I have a trial version out at CPANtesters. Assuming it does as well as 6.13 has done, I'll do a fresh CPAN release later this week.