timburgess / brackets-ftp-sync

FTP/SFTP for Adobe Brackets
105 stars 19 forks source link

FTP upload failed due to 500 error #1

Closed Skeldave closed 10 years ago

Skeldave commented 10 years ago

I'm having a small problem with the uploading. It seems to upload one file and then stops.

I'm using www.000webhost.com free hosting.

[node-log 7:51:14 PM] logged in at // NodeDebugUtils.js:117 [node-log 7:51:14 PM] full remote path is //public_html NodeDebugUtils.js:117 [node-log 7:51:17 PM] uploaded //public_html/Product/index.html NodeDebugUtils.js:117 [node-log 7:51:17 PM] socket fail:Error: 500 Unknown command NodeDebugUtils.js:117 [node-log 7:52:19 PM] ftp transfer stopping NodeDebugUtils.js:117 [ftp-sync] ftp upload stopped

Thanks.

siriokun commented 10 years ago

I have succeed once, but failed after trying again.

When will you fix this?

timburgess commented 10 years ago

I have created a webhost.com account and looked into this error. There are two issues. The first is that the root directory is incorrectly captured as '//' rather than '/'. I have fixed this. But the key issue is the error 500 received on trying to upload the first file. I suspect that either there is an underlying bug in a lower level library or else there is some non-standard behaviour by the webhost.com implementation. Will update after more investigation.

Skeldave commented 10 years ago

Is there any news on this fix? Thanks

timburgess commented 10 years ago

I have brought in patches from the underlying ftp library and also reimplemented the FTP upload code. After some testing, I am now unable to get any errors (beforehand I could get a 500 if I had say two local file changes and a new file in my local directory). There is now an ftp-sync_1.0.3b.zip in the master branch.

To update to the 1.0.3 beta, git pull your cloned working copy to get the new zip file. Then in Brackets, find your extensions directory using Help -> Show Extensions Folder. This will have a subfolder named user which is where the unpacked zip file should go. If FTP-Sync 1.0.2 is already there, be sure to remove it before unpacking the 1.0.3b zip file.

This is beta as events emitted from the node side appear not be showing fully in the dialog box. However, the console is correctly reporting all sync operations and there should be no FTP errors. Please let me know how you go with this. Thanks, TIm

Alternatively, if you git clone the project into your extensions directory, all the new changes are in the libupgrade branch.

timburgess commented 10 years ago

1.0.3 is now available in the Brackets registry. I will close this issue in a few days if no more reports.