search

timburgess / brackets-ftp-sync

FTP/SFTP for Adobe Brackets
105 stars 19 forks source link

Files not uploaded in Brackets, but folders are #10

Open drewmunn opened 10 years ago

drewmunn commented 10 years ago

I'm using this in Edge Code (shh!) and happily creates the relevant folders on the FTP server, but doesn't actually upload any folders. Any thoughts?

Parcye commented 10 years ago

I suggest looking at issue #5 and #7 , I solved it on my local machine by allowing error 450 and 452 to be ignored. As it already ignores 500 and 501

drewmunn commented 10 years ago

I'd already tried allowing 450 but that didn't work, and allowing 452 didn't do anything either unfortunately. I've tried a different network in case that was blocking it, but that doesn't seem to be the issue either.

Parcye commented 10 years ago

What error is showing in the console log?

Verstuurd vanaf remote werkstation

Op 11 mrt. 2014 om 17:21 heeft drewmunn notifications@github.com het volgende geschreven:

I'd already tried allowing 450 but that didn't work, and allowing 452 didn't do anything either unfortunately. I've tried a different network in case that was blocking it, but that doesn't seem to be the issue either.

— Reply to this email directly or view it on GitHub.

drewmunn commented 10 years ago

Absolutely none, I just get "[ftp-sync] started ftp upload" and then nothing happens. Directories are created on the server, and then I wait. Activity Monitor shows no network activity from anything outside of my standard applications, and my FTP server shows no active connections.

drewmunn commented 10 years ago

Scratch that, it's now come back to life and given me an error 400.

Parcye commented 10 years ago

While stating i guess

Verstuurd vanaf remote werkstation

Op 11 mrt. 2014 om 17:43 heeft drewmunn notifications@github.com het volgende geschreven:

Scratch that, it's now come back to life and given me an error 400.

— Reply to this email directly or view it on GitHub.

drewmunn commented 10 years ago

Once it logs in and creates the directories. Then it throws the errors.

drewmunn commented 10 years ago

Never fear, I created a new FTP account on my server and tried with that, and it worked. Thanks anyway!

timburgess commented 10 years ago

Thanks for helping @Parcye I woke up this morning to see the issue in email but github has been down.

This is the first report I've had of FTP-Sync working fine on localhost but not on a remote FTP server. It would be good if you could advise of the name and version of the remote FTP server software.

gstubbenhagen commented 10 years ago

I'm having this issue as well; the FTP sync seems to complete without error but any new files are not uploaded to the server (pre-existing files which were edited are updated on the server and any new folders are created, it's seems to be solely new html, js & css files which are at issue).

At the moment I'm having to go into Dreamweaver to upload the new files to the server so any insight on what might be causing this would be very welcome. For reference I'm using v1.0.4 of the extension in Edge Code CC on a Windows 8.1 PC.

drewmunn commented 10 years ago

@timburgess, sorry I'm not sure of the software; I know it's an Apache server but that's about it. Our digital team manage that side of things. @gstubbenhagen: I also have some issues with new files, especially images that aren't uploaded initially, and I've been forcing them over FileZilla as well. From there on, FTP sync works fine with updates to the problematic files.

timburgess commented 10 years ago

@gstubbenhagen Edge Code CC 0.97 is based on Brackets 34. There will be issues until a newer version of Edge Code Preview is built.

@drewmunn Very strange. FTP-Sync walks the project directory for each sync and there is no caching. It would be useful to know if in the developer tools console, a new file is 'stated' i.e. the log produces a stat lien for each file it is checking

gstubbenhagen commented 10 years ago

@timburgess I've also tried in Brackets 37 and experienced the same issue with that release

Parcye commented 10 years ago

Please be sure you are not getting a results that is a temp error, for example because you are trying to get file info of non existing file. See issue #5 and #7 . I for example just ignore all errors when statting the file in my local version.

drewmunn commented 10 years ago

@timburgess I don't believe Edge Code has built in dev tools, but I've got a plug-in console that only ever reports "[ftp-sync] started ftp upload". My server tracks an upload spike as changed files are copied over, and then it drops back down to nothing. I've tried with .png and .php files and neither are copying over initially. @Parcye the installation I'm currently using is vanilla (I've got a new machine), so I'd only be suppressing errors if the code was written to originally.

timburgess commented 10 years ago

Guys, I'm reopening this issue. Please read over the Troubleshooting page and specifically the last section that covers the details for reporting on an issue. I need to be able to reproduce your issue in order to fix it.

Note too that the upload logic is based on a size comparison - so it is possible to have a change not uploaded if the change happens to result in a file that is exactly the same size as the original. Rare but possible.

For new files, possibly they are being missed somehow when the project path is walked. But as I say, I need details to ascertain how this could happen.

I do appreciate your info & comments on these issues. I would like to get FTP-Sync to the point where nobody has any issues. And I am moving towards having a test FTP server so we can at least have a common server-side when looking at these issues.