search

timbze / first-london-baptist-confession-1646

The OSIS source text for the First London Baptist Confession of Faith of 1646. Also includes addendum by Benjamin Cox.
Other
1 stars 0 forks source link

Top level structure improvement #6

Closed DavidHaslam closed 4 years ago

DavidHaslam commented 4 years ago

IMHO, it would be a useful improvement to insert into the XML structure two top level div elements within the osisText and make all the existing div elements one level lower.

    <div type="majorSection" osisID="Confession">
        ...
    </div>
    <div type="majorSection" osisID="Appendix_Benjamin Cox">
        ...
    </div>

This would better reflect the reality that the module contains two source text documents.

This would also aid module navigation in front-ends.

Once this is done, the osisID for the Cox introduction could be shortened to "Appx_Introduction".

timbze commented 4 years ago

I think that's a good idea. Done here b1b46655

I changed osisID of appendix section to simply Appendix, because And Bible shows the full osisID / chapter osisID for each chapter, so it doesn't look as good. Check out the latest release and let me know if you have any more suggestions.