search

timc1 / kbar

fast, portable, and extensible cmd+k interface for your site
https://kbar.vercel.app
MIT License
4.84k stars 185 forks source link

Fix IME issue in keyboard event handler #274

Closed rakakroma closed 1 year ago

rakakroma commented 1 year ago

Previously, when an IME user (e.g. Chinese, Japanese user) was picking a word, the 'ArrowUp' or 'ArrowDown' keydown would make selected item in the search results changed, and when user hit 'Enter', it would not only pick the word, but also submit at the same time. This commit adds a check for event.isComposing to the event handler to prevent this issue.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
kbar ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 30, 2023 at 0:41AM (UTC)