timcassell / ProtoPromise

Robust and efficient library for management of asynchronous operations in C#/.Net.
MIT License
180 stars 13 forks source link

Prefix `bool`-returning methods with `Try` #211

Closed timcassell closed 1 year ago

timcassell commented 1 year ago

Functions like AsyncMonitor.Wait and Promise.Wait return bool, while common practice is for boolean-returning methods to be prefixed with Try. This was done to closely mimic the existing BCL methods, but I think it makes more sense to update to more sensible method names.

The existing methods don't need to be removed, they can just be deprecated, with suggestions to use the new Try methods.