search

timcharper / calendar_date_select

A previously popular but no longer maintained JavaScript DatePicker for RubyOnRails (and others)
http://code.google.com/p/calendardateselect/
Other
409 stars 179 forks source link

If january 29,30 or 31 selected calendar skips february #16

Closed markovanderpuil closed 13 years ago

markovanderpuil commented 13 years ago

If you enter or select january 29,30 or 31 in the calendar then next month (little greyed out dates from next month at the bottom) are not from february but from march, the calendar is skipping february all together. You can see it by mousing over, or if you select the date it will come up as a date in march, not february.

markovanderpuil commented 13 years ago

Also if you click on next month (>) the calendar will show february but if you select a date it will be date from march, not february.

triemstr commented 13 years ago

I can't seem to replicate this. Is there a link available to your code so I can compare it with mine?

We tried to fix something like this with:

https://github.com/timcharper/calendar_date_select/commit/8b627ca6a7f7e0edae39305847c691a4e778c442

in issue: https://github.com/timcharper/calendar_date_select/issues/closed#issue/11

markovanderpuil commented 13 years ago

Indeed this fixes the issue, however the gem still has the old code. When would a new version be released?

triemstr commented 13 years ago

Ah, that's true. I don't see much action on this library. I'll ask the person that merged my change last year if he can generate a new gem. You could also create an issue for it and I can up-vote it and we'll see what happens. Thanks.

triemstr commented 13 years ago

Shih-gian Lee (sglee77) pushed a new gem. I'd thank him if you get a chance since he got on it pretty quick.

And thank you for helping to motivate me to ask for it too. Thanks.

Kevin