search

timcharper / calendar_date_select

A previously popular but no longer maintained JavaScript DatePicker for RubyOnRails (and others)
http://code.google.com/p/calendardateselect/
Other
409 stars 179 forks source link

Update calendar_date_select.rb #50

Closed zedtux closed 6 years ago

zedtux commented 7 years ago

Includes FormHelpers and IncludesHelper in the ActionView::Base instead of ActionView::Helpers.

zedtux commented 7 years ago

Using this gem alone was working fine until I start to use another gem which was doing a ActionView::Base.send(:include, ...).

I don't understand why, but the next gem doing the include on the ActionView::Base removes the calendar_data_select_tag. This commit make all working all together.

zedtux commented 7 years ago

@timcharper any chance you have a look at this PR please?

zedtux commented 7 years ago

@marcandre can you please have a look at this PR?

marcandre commented 7 years ago

I think this gem is not really supported anymore. Moreover I don't understand the details of this change, nor how your original issue happens, sorry...

zedtux commented 7 years ago

Thank you @marcandre for your comment.

I think this gem is not really supported anymore.

I can believe it but unfortunately the project I'm migrating is using it and we aren't ready to remove it yet (but should happen one day).

I don't understand the details of this change, nor how your original issue happens

This change fixes the compatibility of this gem with other gems injecting view helpers in Rails. This gem works when running alone, but adding another gem injecting helpers makes calendar_date_select no more working.

This PR fixes this by using the normal way of adding helpers in the view context.

zedtux commented 6 years ago

I'm no more working on that migration project, closing the PR.