timcharper / calendar_date_select

A previously popular but no longer maintained JavaScript DatePicker for RubyOnRails (and others)
http://code.google.com/p/calendardateselect/
Other
409 stars 179 forks source link

Rails 3 ? #6

Closed TeuF closed 11 years ago

TeuF commented 14 years ago

How does it work with rails 3 ?

shihgianlee commented 14 years ago

We have not tested it with Rails 3. Any help in making CDS works with Rails 3 is welcomed!

paneq commented 14 years ago

http://github.com/paneq/calendar_date_select/tree/rails3test I made few commits to make it work with rails3. However I'm not sure how to fix tests. I'll leave it to you as a homework :-)

danabr commented 14 years ago

I would also like to see rails 3 support. paneq's work looks promising. To bad we can't install calendar_date_select as a plugin, that would have made using paneq's version so much easier.

mryan43 commented 14 years ago

@danabr : Bundler to the rescue ! try this out in your Gemfile :

gem 'calendar_date_select', :git => 'http://github.com/paneq/calendar_date_select.git', :branch => 'rails3test'

then run "bundle install" and you're good to go.

I don't think a plugin would really be that much easier :P

danabr commented 14 years ago

Ah, forgot about the wonderful bundler. Thank you a bunch!

barmstrong commented 14 years ago

nice!

triemstr commented 13 years ago

To get 1.16.2 fixes, can just get it from paneq's master now instead of the rails3test branch.

gem 'calendar_date_select', :git => 'http://github.com/paneq/calendar_date_select.git'

Thank you paneq! Any thoughts of doing a pull request, paneq?

paneq commented 13 years ago

I couldn't make the tests running in my branch. That's why I haven't created pull request yet.

marcandre commented 11 years ago

Version 2.0.0 now supports Rails 3.1+. Thanks