search

timche / docker-csgo

Counter-Strike: Global Offensive (CS:GO) Dedicated Server with automated/manual updating and optional SourceMod and PugSetup/PracticeMode integrations
https://hub.docker.com/r/timche/csgo
MIT License
193 stars 27 forks source link

Add wait-for-it #3

Closed Gelmo closed 4 years ago

Gelmo commented 4 years ago

Add wait-for-it to image for admins who would like to run separate docker containers for each instance of srcds. This allows you to share a single installation volume across multiple containers, while ensuring that updates are only run on a single container. For example:

https://github.com/Gelmo/warfork-docker/blob/master/docker-compose.multi-container.yml

In that example, warfork2 and warfork3 wait until port 44450 is open on warfork1 before running the entrypoint script. The same functionality is available with HEALTHCHECK, but this tool allows for similar functionality when checking instances on another node/host/stack

Gelmo commented 4 years ago

Forgot to link to related pages:

https://github.com/vishnubob/wait-for-it https://tracker.debian.org/pkg/wait-for-it

timche commented 4 years ago

I like this idea and I see a use case, but my general intention with this image is to keep it as small as possible (although wait-for-it is relatively small) and just install the essentials. My suggestion is that you create another image based on timche/csgo instead and install wait-for-it there.

Gelmo commented 4 years ago

Understandable, and that is exactly how I will proceed. Thank you for considering.