search

timche / gmail-desktop

:postbox: Nifty Gmail desktop app for macOS, Linux & Windows
MIT License
832 stars 91 forks source link

Update custom styles #135

Closed mskelton closed 5 years ago

mskelton commented 5 years ago

Hey Tim, long time no speak! I hope all is well.

I switched back to using gmail desktop a month or two ago and I wanted to contribute some more to the project. The first thing that was bugging me was the custom styles not working. As I mentioned in https://github.com/timche/gmail-desktop/issues/121, I reworked the custom styles to be based on element position rather than class names. We can see how it works but I am hoping it will be much more stable than the class name approach. Additionally, I commented on every line of the stylesheet as there were styles in the old stylesheet that I had no idea why they were there because the class names have since changed. By keeping every style commented, we can always fix the selectors because we know the intent of the style.

timche commented 5 years ago

Welcome back @markypython! I've been very busy recently and couldn't find any time to improve Gmail Desktop unfortunately. I really appreciate your contributions!

If you could fix the CI errors, I'm more than happy to merge this PR :)

mskelton commented 5 years ago

I have fixed the stylelint warnings that were causing the build to fail. For some reason it let me commit the file even though there were errors. Not sure why.

timche commented 5 years ago

Awesome, thank you!