search

timche / gmail-desktop

:postbox: Nifty Gmail desktop app for macOS, Linux & Windows
MIT License
845 stars 90 forks source link

Custom style settings #138

Closed mskelton closed 5 years ago

mskelton commented 5 years ago

This adds three additional settings for custom styles to allow finer control of hiding elements. More details are explains in #108.

I have no migration function in this PR to migration from the old settings to these new settings as I wanted to get this out there to get your feedback so I was sure that the rest of the code isn't changing.

I also added a ConfigKey enum so that we don't have a bunch of magic strings floating around for the config keys.

Fixes #108

timche commented 5 years ago

Awesome work as always, really appreciate it someone is taking such good care 👍 💯

mskelton commented 5 years ago

@timche As mentioned in my comment, I hadn't added migration to this PR. Please don't release again until I can add that migration from the old minimal mode to the new one.

timche commented 5 years ago

Oh, alright. Misunderstood that part, sorry. Waiting for another PR then.

mskelton commented 5 years ago

@timche I was thinking a bit more about the migration strategy for minimal mode and I think the best option is to just release without a migration. The reason for that is the description of #108 is turn on minimal mode by default. Since we don't know which users explicitly tried and then turned off minimal mode, we don't know if we should leave it turned off or turn it on as the new default.

Does that make sense?

timche commented 5 years ago

Sure, fine for me, thanks!