search

timche / gmail-desktop

:postbox: Nifty Gmail desktop app for macOS, Linux & Windows
MIT License
845 stars 90 forks source link

Add .rpm package to existing linux build targets (fixes #91) #152

Closed cyfrost closed 5 years ago

cyfrost commented 5 years ago

This fixes issue #91

mskelton commented 5 years ago

@cyfrost Should we add pacman, snap, and tar.bz2 as well?

mskelton commented 5 years ago

@cyfrost I would also suggest adding the zip target for Windows as that was mentioned in #91

i.e.

"win": {
  "target": [
    "nsis",
    "zip"
  ]
}
cyfrost commented 5 years ago

Updated build targets will be:

For Linux: .deb, .rpm, .snap, .pacman, .AppImage, .tar.bz2

For Windows: .nsis, .zip

Although, Electron Builder did warn me about this:

image

mskelton commented 5 years ago

Although, Electron Builder did warn me about this:

@cyfrost I'm going to be looking into upgrading to Electron 6 again but the original problem we had was related to custom styles/preload scripts not working in windows opened with window.open. I'll have to check and see if it is still a problem.