search

timche / gmail-desktop

:postbox: Nifty Gmail desktop app for macOS, Linux & Windows
MIT License
845 stars 90 forks source link

fix issue #88 by adding option to hide Menu bar #159

Closed cyfrost closed 5 years ago

cyfrost commented 5 years ago

This fixes #88 by adding a configurable option to set the visibility of the Menu bar for those who want to change it.

When the Menu bar is hidden, we can hit the Alt key once to bring it up.

image

With Menu bar visible (current look):

image

With Menu bar hidden (new look):

image

Thoughts?

cyfrost commented 5 years ago

I noticed that this setting is available on all platforms, but it should only be configurable on Linux and Windows. The menu bar on macOS is integrated on system level on top. Otherwise I'm happy to with this feature.

Ah, thanks for pointing it out. I keep forgetting macOS every time, silly me! Let me fix this.

cyfrost commented 5 years ago

@timche As discussed, this commit adds checks for Linux/Windows before allowing Menu bar visibility changes.

timche commented 5 years ago

Thanks a lot! 👏