search

timche / gmail-desktop

:postbox: Nifty Gmail desktop app for macOS, Linux & Windows
MIT License
832 stars 91 forks source link

Support dark mode ? #195

Closed duongleh closed 4 years ago

duongleh commented 4 years ago

image

I know there is a default dark mode, but can you adopt this way of style in your app. Greate app, btw

mskelton commented 4 years ago

This was discussed in #75 where we decided to not create a custom dark mode in favor of the default Gmail dark theme. Maintaining custom styles for Gmail is super hard as their class names are meaningless and you often has to rely on the dom structure instead.

duongleh commented 4 years ago

@mskelton thanks for your answer. As I don't want to open another issue just for a question, I will put it here: How can I enable push notification, for example, something like this shows up when a new email arrives? image

mskelton commented 4 years ago

Have you enabled desktop notifications in gmail? This article explains how to: https://support.google.com/mail/answer/1075549?co=GENIE.Platform%3DDesktop&hl=en

duongleh commented 4 years ago

Got that working, thanks

ipkpjersi commented 4 years ago

I attempted to enable dark mode through Gmail settings but it appears I am missing the settings button:

Should I create a new issue for this? I am not sure if this is worth creating an issue for or if this is an issue with Gmail itself and not with this app?

cipriancraciun commented 4 years ago

@ipkpjersi Go in the gmail-desktop menu (by pressing Alt if it is hidden), then Settings > Appearance > Hide Support and uncheck that. Then you can see the usual GMail settings button in the usual place.

ipkpjersi commented 4 years ago

That worked, thanks.

Although I do wish the body of emails had a dark background with white text, that would be cool.

cipriancraciun commented 4 years ago

Although I do wish the body of emails had a dark background with white text, that would be cool.

:) Yes... I used to have a custom user-style (this is something that gmail-desktop supports now) that would override those colors, but reverse engineering GMail's theme CSS classes is like trying to reverse-engineer assembler code...

So it is technically possible, but its something strictly tied to the theme you are choosing, and unfortunately can break at any moment due to changes done by GMail's team.

timche commented 3 years ago

Added dark mode in https://github.com/timche/gmail-desktop/releases/tag/v2.24.0