Add Apple Silicon support - Githubissues

timche / gmail-desktop

:postbox: Nifty Gmail desktop app for macOS, Linux & Windows

MIT License

832 stars 91 forks source link

Add Apple Silicon support #224

Closed diocletiann closed 3 years ago

diocletiann commented 3 years ago

Electron 11 supports arm64, would it be possible to get native build? Love the app, thanks!

timche commented 3 years ago

Electron will be upgraded to v11 in #223. Please stay tuned.

timche commented 3 years ago

@restfuladi can you please test if the arm64 version works in this test build? https://github.com/timche/gmail-desktop/suites/2194117774/artifacts/45264896

diocletiann commented 3 years ago

@restfuladi can you please test if the arm64 version works in this test build? https://github.com/timche/gmail-desktop/suites/2194117774/artifacts/45264896

I just installed the .dmg from the download and Activity Monitor says "Architecture Intel"

timche commented 3 years ago

Thanks. I'm currently building an universal app for you to try again. Will let you know when it has finished building.

timche commented 3 years ago

New test build: https://github.com/timche/gmail-desktop/suites/2194300285/artifacts/45269589

diocletiann commented 3 years ago

Stuck here, yubikey is inserted.

timche commented 3 years ago

Can you elaborate please? Is it frozen? Did you try multiple times?

diocletiann commented 3 years ago

Yes tried it multiple times. It's not frozen, the animated blue line keeps cycling and the page is waiting for the security key without failing over to the "try a different way" screen.

timche commented 3 years ago

Can you please try the test build and latest release again, just to verify that it's not an issue with Gmail or the security key itself.

diocletiann commented 3 years ago

It was my mistake, it was expecting me to touch the key. The UI doesn't change at all when you insert it so I assumed it wasn't detected. Once I touched it, log in succeeded and the app seems to be working normally.

timche commented 3 years ago

Can you confirm that the process architecture is arm64 or whatever it is for Apple Silicon?

diocletiann commented 3 years ago

Looks good. It would say Intel otherwise.

timche commented 3 years ago

Awesome, thanks. I'll release this.

timche commented 3 years ago

Released in v2.21.1.

timche commented 3 years ago

Can you give me a final confirmation that this release is also working please?

diocletiann commented 3 years ago

I haven't seen any issues yet unique to this build. Sent a few emails and archived a few more, so far so good. Thanks for quick update!

timche commented 3 years ago

Great, thank you for testing so quickly and being so responsive!