search

timche / gmail-desktop

:postbox: Nifty Gmail desktop app for macOS, Linux & Windows
MIT License
845 stars 91 forks source link

Keyboard shortcuts add indentation #227

Closed eriktdesign closed 1 year ago

eriktdesign commented 3 years ago

Steps to Reproduce:

  1. Compose a message
  2. Use a keyboard shortcut with Cmd (eg Cmd+V, Cmd+B, etc)
  3. Current line of compose is indented

For some reason whenever I paste text, or try to make formatting changes using keyboard shortcuts, the current line of text is indented. The line becomes indented one more level each time I press a Cmd+whatever key combination.

timche commented 3 years ago

I've experienced this before as well, but it's not happening at the moment.

Can you please check if it's still happening in this test build? https://github.com/timche/gmail-desktop/suites/2194117774/artifacts/45264896

eriktdesign commented 3 years ago

@timche I just tested on that build -- still getting the indents.

timche commented 3 years ago

We've released few more version since I asked. Can you please install and test the latest version (v2.25.0) and report back. If you've time, can you also test the latest v3.0.0-alpha pre-release (v3.0.0-alpha.3)?

eriktdesign commented 3 years ago

@timche Doesn't appear to be happening in v3.0.0-alpha.10 -- I'll keep you posted

timche commented 3 years ago

Thanks for letting me know. We can re-open this issue when it's happening again.

eriktdesign commented 3 years ago

Welp. I just updated to Version 3.0.0-alpha.13 (3.0.0-alpha.13) and it's happening again.

timche commented 3 years ago

Can you please check if this actually caused by an update and see if previous versions work fine?

Also please check if this not system/app related. Possible things to check:

timche commented 2 years ago

I finally found the root cause of this issue: The custom user agent is loading a slightly different version of Gmail and causes the drag and drop to behave weirdly in Electron.

So if you have this issue, please try disabling Use User Agent Fix or removing any custom user agent and use the default user agent instead.

Please let me know if it works for you.

eriktdesign commented 2 years ago

I think this may have worked. I don't recall setting a custom user agent, but I went ahead and did Preferences -> User Agent -> Remove Custom User Agent and I haven't seen the behavior since. I'll update here if I see it again.