timche / gmail-desktop

:postbox: Nifty Gmail desktop app for macOS, Linux & Windows
MIT License
832 stars 91 forks source link

fix settings button alignment in compact header #305

Closed DinCahill closed 2 years ago

DinCahill commented 2 years ago

I simply took the padding and margin values from here:

chrome info

And it just worked...

Before:

mac before

After:

mac after

Tested on Mac and Windows.

DinCahill commented 2 years ago

It still looks good when chat it set to Hangouts or Off.

Resolves #304 and #284.

timche commented 2 years ago

Awesome work! Thanks a lot.

Since I don't have Google Chat, could you also open another PR that changes height of the Google Chat Active element please?

Like this:

153630192-14bd64f8-a843-4ecd-9f22-b4c82d3a65a9
DinCahill commented 2 years ago

No problem. I'll look into it.

timche commented 2 years ago

@all-contributors please add @DinCahill for code

allcontributors[bot] commented 2 years ago

@timche

I've put up a pull request to add @DinCahill! :tada: