timche / gmail-desktop

:postbox: Nifty Gmail desktop app for macOS, Linux & Windows
MIT License
832 stars 91 forks source link

improve the look of the sign-in page in dark mode #309

Closed DinCahill closed 2 years ago

DinCahill commented 2 years ago

The code is a bit janky, but the screenshots are pretty.

Before:

before

After:

after

Light mode for reference:

light
timche commented 2 years ago

I've noticed this bug too, but it's inconsistently happening. I wonder what the cause of it is actually.

timche commented 2 years ago

I'm waiting with merging this, because I'm a little worried of the hardcoded classes which are prone to change as they are dynamic and afaik the sing-in page looks different depending on the browser. There is a slight chance this fix may not work for the user agents on Windows and Linux and has to be verified.

timche commented 2 years ago

As assumed, the sign-in page is broken depending on the user agent. I'm using macOS.

With Use User Agent Fix disabled:

Screen Shot 2022-02-12 at 14 02 25

With Use User Agent Fix enabled:

Screen Shot 2022-02-12 at 14 02 40

timche commented 2 years ago

I'll merge this for now as it would fix the sign in page for custom user agents at least.