timche / gmail-desktop

:postbox: Nifty Gmail desktop app for macOS, Linux & Windows
MIT License
832 stars 91 forks source link

Notifications aren't working on Windows #324

Closed DonaldDuck313 closed 2 years ago

DonaldDuck313 commented 2 years ago

OS Windows 11

Gmail Desktop Version 2.25.3.0

Describe the bug I'm not getting notifications on Windows.

Steps to reproduce the behavior

  1. Open Gmail Desktop
  2. Ask someone to send you an email
  3. You won't get a notification

Expected behavior I expect to get a notification whenever I get a new email.

Additional context If I look at your source code, it looks like you use Electron notifications. According to the documentation,

On Windows 10, a shortcut to your app with an Application User Model ID must be installed to the Start Menu.

(It doesn't say anything about Windows 11 so I assume that also applies to Windows 11.)

I don't know anything about Electron so I'm not sure how to fix this, but it would be nice if you could have Gmail Desktop somehow automatically add this shortcut with an Application User Model ID.

timche commented 2 years ago

Have you enabled desktop notifications in Gmail?

DonaldDuck313 commented 2 years ago

Have you enabled desktop notifications in Gmail?

Thanks, it worked. It's not clear from your documentation that I need to do that though, I assumed that it worked like the official Android app where notifications are on by default. Maybe you should clarify that in your documentation, something like this.