search

timche / gmail-desktop

:postbox: Nifty Gmail desktop app for macOS, Linux & Windows
MIT License
822 stars 90 forks source link

Icons are blank on new Material You Design #336

Open ghost opened 2 years ago

ghost commented 2 years ago

OS macOS

Gmail Desktop Version Version: 3.0.0-alpha.34 (dev)

Describe the bug With the new material you gmail design icons are not showing...

Steps to reproduce the behavior

Expected behavior Icons should be shown

Media https://ibb.co/vZ3N75C

infinitnet commented 2 years ago

Same here.

infinitnet commented 2 years ago

@timche alpha 35 didn't fix it for me (cleared cache as well). 2022-08-10_21-22

timche commented 2 years ago

It looks okay for me. @infinitnet please give it 24-48 hours and check again after. I've the assumption that it's something server-side that's blocking the requests to load the icons and is cached per user basis.

Screenshot 2022-08-10 at 20 32 17
infinitnet commented 2 years ago

@timche hasn't been 48 hours yet, but close and 3 reboots later - problem still persists on my end. Would be cool to get feedback from @boki000 as well.

timche commented 2 years ago

@infinitnet this is very weird. Can you please share your user agent settings? You can find them at Preferences -> User Agent.

infinitnet commented 2 years ago

@infinitnet this is very weird. Can you please share your user agent settings? You can find them at Preferences -> User Agent.

"Use User Agent Fix"

timche commented 2 years ago

@infinitnet can you please disable "User User Agent Fix" and make sure that "Remove Custom User Agent" is disabled too?

Kind of like this:

Screenshot 2022-08-12 at 11 35 38
infinitnet commented 2 years ago

@timche Unchecking "User User Agent Fix" did the trick! But only after clearing cache as well. Looks like you should adjust default settings and disable "User User Agent Fix" + force clear cache post install with the next update. Unless mine was an isolated case. :)

ghost commented 2 years ago

alpha 35 didn't fix it for me. WIll try with User Agent fix

ghost commented 2 years ago

fixed 🚀

timche commented 2 years ago

@JohnLGalt do you still have this issue? If yes, can you please try my suggestion above?

JohnLGalt commented 2 years ago

@JohnLGalt do you still have this issue? If yes, can you please try my suggestion above?

I unchecked 'User User Agent Fix' and restarted but it did not change the block icons (and 'Remove' was disabled).

But with 'Use User Agent Fix' I am unable to use my Titan Security keys with the Advanced Protection I have enabled across all my accounts. So, I reverted to having it enabled since the icons did not show with that setting unchecked.

JohnLGalt commented 2 years ago

@JohnLGalt do you still have this issue? If yes, can you please try my suggestion above?

Update. After re-enabling the 'User User Agent Fix' I saw something curious happen right in front of me as I was using it.

I have 3 Google accounts and 4 G-Suite accounts in there, and as I progress through the first 2 Google accounts, and the 4 G-Suite accounts, no icons. When I got the the last account, a Google account, icons were there. I checked all the other accounts, and no icons - but, wait, after I went back to the last account, and went back sequentially, I started seeing some icons. By the time I made it to the first account, icons were there fully - but 3 of my G-Suite accounts show no icons, the rest show icons.

As I continue to fool with it, one more G-Suite account is showing icons. The remaining two are showing icons only on folders that are open (so Inbox icon shows when I am in the Inbox, and Important icon shows when I am in the Important folder, etc.

And, again, this is with user agent fix enabled.

JohnLGalt commented 2 years ago

Update - after a restart, all accounts are only showing icons selectively. I suspect that the icons started showing for the brief time I had User Agent fix disabled, and only reverted after I fully re-started my computer.

At any rate, until I get around to adding those accounts to my phone so I can have an alternate method to authenticate, I'm stuck using user agent fix, and thus stuck with limited icons.

timche commented 2 years ago

Thanks for those updates @JohnLGalt. Have you also tried "Clear Cache" and "Reset App Data" (both under Help -> Troubleshooting) after disabling User Agent fix?

JohnLGalt commented 2 years ago

Thanks for those updates @JohnLGalt. Have you also tried "Clear Cache" and "Reset App Data" (both under Help -> Troubleshooting) after disabling User Agent fix?

Nope - I'll give those a try, thanks!

WebShapedBiz commented 2 years ago

On elementaryOS Linux, removing Hardware Acceleration is what did it for me, nothing else, so maybe this could help someone.

JohnLGalt commented 2 years ago

Thanks for those updates @JohnLGalt. Have you also tried "Clear Cache" and "Reset App Data" (both under Help -> Troubleshooting) after disabling User Agent fix?

So, here is what I had to do.

  1. Reset App Data - at this point all accounts and settings are lost. I then start Gmail-Desktop and notice that, by default, Use User Agent Fix is enabled. This is good, as I need to add 7 accounts all of which are enrolled in Advanced Protection.
  2. Add each account and verify all is working except for icons
  3. Disable 'Use User Agent Fix'
  4. Clear Cache

At this point icons work on all 7 accounts. I suspect that most people who have Advanced Protection enabled may have to go through this same set of steps to both get their accounts working and have the icons showing with the 'new GMail'.

For any GSuite accounts with Advanced Protection enabled, if there is only the same 30 timeout before you'll need to authenticate with your key again, you'll simply need to enable "Use User Agent Fix' setting, then can authenticate, and then after all your accounts are authenticated, disable it again to have working icons. (Normal Google accounts will allow you to trust the app so authentication is not required again).

HTH

timche commented 1 year ago

Great that this workaround also works for you @JohnLGalt. I'll probably change the way how User Agent Fix works, because the Firefox user agent makes Gmail buggy for some reason, so instead the User Agent Fix could be applied only during the signing in phase and then switch back to default (Chrome) once signed in.

JohnLGalt commented 1 year ago

Great that this workaround also works for you @JohnLGalt. I'll probably change the way how User Agent Fix works, because the Firefox user agent makes Gmail buggy for some reason, so instead the User Agent Fix could be applied only during the signing in phase and then switch back to default (Chrome) once signed in.

Nice. I've got all my accounts with Advanced Protection enabled already added, but your implementation is so easy, I don't mind resetting data again for testing. Otherwise, it's working great!

spmarsden commented 1 year ago

I've just run into the same issue. Arch linux, GNOME DE, Gmail Desktop 3.0.0-alpha.35

The fix described above worked for me:

Everything looks to display properly afterwards.

eshack94 commented 1 year ago

I'm experiencing the same issue on Apple Silicon (ARM) based MacBook Pro. Just wanted to confirm that the fixes described above fixed the problem. 2 Restarts were required. Restart the app once after unchecking "Use User Agent Fix", then restart again after doing "Clear Cache".

Thanks all.

JohnLGalt commented 1 year ago

Great that this workaround also works for you @JohnLGalt. I'll probably change the way how User Agent Fix works, because the Firefox user agent makes Gmail buggy for some reason, so instead the User Agent Fix could be applied only during the signing in phase and then switch back to default (Chrome) once signed in.

I came upon time to re-login to my G-Suite (WorkSpace) accounts. Enabling User Agent allowed me to log in with Security keys, and then disabling User Agent and clearing cache brought the new theme's icons back.

This workaround works perfectly fine. I wonder if there is a more permanent fix, using an alternative User Agent fix that will satisfy both the new theme and the need to access physical security keys for Advanced Protection.

JohnLGalt commented 1 year ago

I just had to go do another round of re-logins for my WS accounts. All accounts, both WS and non-WS are using the new MY UI.

After enabling the user agent fix (so I could use my Solo key to authenticate my accounts) I cleared cache and forgot to uncheck the User agent fix - and yet all icons are working normally!

@timche Did this resolve itself from Google's end?