timchurches / Mutated-Mutables

Various enhancements, experiments and outright hacks of Mutable instruments firmware code
http://timchurches.github.io/Mutated-Mutables/
150 stars 30 forks source link

Peaks v1.1 #2

Closed boourns closed 4 years ago

boourns commented 7 years ago

@timchurches

This ports v1.1 of peaks code to Peaks DMC. I started with the code from @johnfolkesson's branch, and then applied https://github.com/pichenettes/eurorack/commit/26f0ec7a60b94b4c73b6cd04eb786cbf0d42b7ef

At this point I've tested all the DMC functionality in Twin mode, but not split or expert. Also, I mostly tested just Ch1.

boourns commented 7 years ago

I just noticed that upstream has bumped stmlib dependency, so I've bumped it here.

This branch works without stmlib bumped, but peaks tests won't compile. Some of the commits seem related to the peaks update so if possible it'd be better to include it in the patch, but it also means that this PR now affects the other alternate firmwares in this repo.

Currently this PR has the stmlib bump (last commit, just added)

timchurches commented 7 years ago

Unfortunately, my ancient Mac Pro which had my Mutables toolchain on it has died (or at least it refuses to boot, although has mirrored discs and back-ups so recoverable, but no time to fiddle with it right now), so I'll need to set up a new one on my MacBook Pro. So no progress over the weekend. It shouldn't take long to install the toolchain. I have theST/linkV2 programmer hooked up to my test module again (I had temporarily misplaced it).

On 17 July 2017 at 11:25, Tom Burns notifications@github.com wrote:

I just noticed that upstream has bumped stmlib dependency, so I've bumped it here.

This branch works without stmlib bumped, but peaks tests won't compile. Some of the commits seem related to the peaks update so if possible it'd be better to include it in the patch, but it also means that this PR now affects the other alternate firmwares in this repo.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/timchurches/Mutated-Mutables/pull/2#issuecomment-315652716, or mute the thread https://github.com/notifications/unsubscribe-auth/ACugYcm4-_L6hvloHSXrbdJUSM5Z4QY7ks5sOrf-gaJpZM4OXurg .

boourns commented 7 years ago

I'm in no rush, take your time.

I realized there's like 50k of space so I'm working on a sample-based drum player.

On Jul 16, 2017, at 9:49 PM, Tim Churches notifications@github.com wrote:

Unfortunately, my ancient Mac Pro which had my Mutables toolchain on it has died (or at least it refuses to boot, although has mirrored discs and back-ups so recoverable, but no time to fiddle with it right now), so I'll need to set up a new one on my MacBook Pro. So no progress over the weekend. It shouldn't take long to install the toolchain. I have theST/linkV2 programmer hooked up to my test module again (I had temporarily misplaced it).

On 17 July 2017 at 11:25, Tom Burns notifications@github.com wrote:

I just noticed that upstream has bumped stmlib dependency, so I've bumped it here.

This branch works without stmlib bumped, but peaks tests won't compile. Some of the commits seem related to the peaks update so if possible it'd be better to include it in the patch, but it also means that this PR now affects the other alternate firmwares in this repo.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/timchurches/Mutated-Mutables/pull/2#issuecomment-315652716, or mute the thread https://github.com/notifications/unsubscribe-auth/ACugYcm4-_L6hvloHSXrbdJUSM5Z4QY7ks5sOrf-gaJpZM4OXurg .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/timchurches/Mutated-Mutables/pull/2#issuecomment-315654280, or mute the thread https://github.com/notifications/unsubscribe-auth/AAqsnpdCWb5s9Dpg38F5DsTuQbS1ex5Eks5sOr2hgaJpZM4OXurg.

timchurches commented 7 years ago

Someone went to the trouble of recording some samples, in a professional studio with high-end mikes etc, for inclusion in DMC. I'll see if I can find them and send them to you.

On 17 July 2017 at 11:51, Tom Burns notifications@github.com wrote:

I'm in no rush, take your time.

I realized there's like 50k of space so I'm working on a sample-based drum player.

On Jul 16, 2017, at 9:49 PM, Tim Churches notifications@github.com wrote:

Unfortunately, my ancient Mac Pro which had my Mutables toolchain on it has died (or at least it refuses to boot, although has mirrored discs and back-ups so recoverable, but no time to fiddle with it right now), so I'll need to set up a new one on my MacBook Pro. So no progress over the weekend. It shouldn't take long to install the toolchain. I have theST/linkV2 programmer hooked up to my test module again (I had temporarily misplaced it).

On 17 July 2017 at 11:25, Tom Burns notifications@github.com wrote:

I just noticed that upstream has bumped stmlib dependency, so I've bumped it here.

This branch works without stmlib bumped, but peaks tests won't compile. Some of the commits seem related to the peaks update so if possible it'd be better to include it in the patch, but it also means that this PR now affects the other alternate firmwares in this repo.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/timchurches/Mutated-Mutables/ pull/2#issuecomment-315652716, or mute the thread https://github.com/notifications/unsubscribe-auth/ACugYcm4-_ L6hvloHSXrbdJUSM5Z4QY7ks5sOrf-gaJpZM4OXurg .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ timchurches/Mutated-Mutables/pull/2#issuecomment-315654280, or mute the thread https://github.com/notifications/unsubscribe-auth/ AAqsnpdCWb5s9Dpg38F5DsTuQbS1ex5Eks5sOr2hgaJpZM4OXurg.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/timchurches/Mutated-Mutables/pull/2#issuecomment-315654496, or mute the thread https://github.com/notifications/unsubscribe-auth/ACugYe8rSOUEWhB2rcXyM0nQOrG9A1oRks5sOr44gaJpZM4OXurg .

timchurches commented 7 years ago

Here we are: hi-hat samples recorded for DMC, already down-sampled, plus a demo of them in a loop.

loop1.m4a.zip

downsample.zip

Need to credit Michael Brawer with doing these, but they are unencumbered and free for use in DMC.

boourns commented 7 years ago

I opened an issue describing the sample player I've got in mind as I won't be adding it to this PR, I'm interested in your thoughts.

boourns commented 7 years ago

@timchurches IMO this PR should get merged and shipped soon as it fixes the bugs discussed in the muffwiggler thread where the CPU lags and the LFOs mess up

The sample player can sit as a PR for now as (IMO) it could use better samples than what I've managed to put together. It's worth a play though.

timchurches commented 7 years ago

Ok, thanks, will review it tonight.

johnfolkesson commented 7 years ago

Hey just to let you guys know I´m running the code from my original PR on 2 different peaks and everything appears to be working just fine.

skinlayers commented 1 year ago

@timchurches @boourns I noticed this PR was merged ~3 years ago, but a new binary was never released. I've seen @forestcaver 's binary of @johnfolkesson 's v3 calibration PR floating out in the wild, among others. I was wondering if there were any known issues after PR #2 was merged that would prevent binary distribution?

I've worked out how to compile the latest code using pichenettes/mutable-dev-environment, and was wondering if there was any reason I shouldn't distribute a hex and/or wav version for those requesting it?

Thank you!