search

timdavish / fml-cli

A cli for serving fml stories to your terminal.
https://www.npmjs.com/package/fml-cli
MIT License
0 stars 0 forks source link

FML shows undefined #1

Open CherryNerd opened 5 years ago

CherryNerd commented 5 years ago

When running any fml command other than version or help, it just returns undefined.

Running on: MacOS Node 12.0.0 NPM 6.9.0

timdavish commented 5 years ago

Without looking too far into it, I would assume this is due to a change in the FML website's DOM tree. This package attempts to find the FML text in the DOM here: https://github.com/timdavish/fml-cli/blob/master/cli.js#L71

Taking a quick glance at FML's website through dev tools (the random page in particular - https://www.fmylife.com/random) I can see that p.block is no longer the element/class combination that contains the FML text. My guess is that changing this selector to a.article-link would fix this problem.

If you'd like to submit a PR, I'd be happy to bring this in :)