search

timderspieler / DeluxeCombat-Issues

Official repository for feature requests and bug reports related to DeluxeCombat
0 stars 0 forks source link

[Bug] Hpets potion effects while in pvp #11

Closed ArcticTroxx closed 2 years ago

ArcticTroxx commented 2 years ago

Has this issue already been reported? Did you ask for help before making this report?

DeluxeCombat Version

Server Software / Version

Paper 1.19

Your discord name

ArcticTroxx#8618

Current Behavior

While a player has a pet equipped they receive a potion effect (example: saturation). This will heavily impact the pvp aspect of the server if the effect isn't removed while in pvp.

Expected Behavior

I would like the effects to be disabled once in pvp and to turn back on once out of combat tag.

Steps To Reproduce

Enable a pet with an effect (example: saturation)

Attack a player

See that the effect is still there while in combat tag.

Frequency

100% of the time.

Anything else?

Nope, thank you for your time.

timderspieler commented 2 years ago

Status: Waiting for the HPet author to get back from his vacation.

timderspieler commented 2 years ago

Solved with: https://github.com/Heron4gf/hpet/commit/24ba6088f1ce1d17c27a9b2dc815b30550c90e95