search

timdeschryver / ngrx-immer

Immer wrappers around NgRx methods createReducer, on, and ComponentStore
https://www.npmjs.com/package/ngrx-immer
MIT License
120 stars 7 forks source link

Add immer implementations of @ngrx/signals #21

Closed timdeschryver closed 7 months ago

timdeschryver commented 1 year ago

Coming from https://github.com/ngrx/platform/issues/3998

xianshenglu commented 9 months ago

@timdeschryver Hi, any update for this feature?

timdeschryver commented 8 months ago

@xianshenglu this needs to be implemented 😅 If you want to contribute, feel free to drop your a comment here and it will get assigned to you

timdeschryver commented 8 months ago

@rainerhahnekamp I'm assigning this to you. I've added the "infrastructure" so you can focus on the "good stuff". Feel free to ping me if you need help.

rainerhahnekamp commented 8 months ago

Alright, thanks Tim and I'll contact you if I have any questions or just push the PR once it is ready

rainerhahnekamp commented 8 months ago

Quick update here. PR should be ready by tomorrow. Should give us enough time for a proper review and improvements before Marko's talk at ng-conf.

timdeschryver commented 8 months ago

Thanks @rainerhahnekamp

rainerhahnekamp commented 8 months ago

@timdeschryver, there is a little bit of a problem with the testing. To verify that only the patched Signals emit, I need to use TestBed.flushEffects().

I'll have to add Jest in that case. I prefer Jasmine, but that might be an overkill.

timdeschryver commented 8 months ago

@timdeschryver, there is a little bit of a problem with the testing. To verify that only the patched Signals emit, I need to use TestBed.flushEffects().

I'll have to add Jest in that case. I prefer Jasmine, but that might be an overkill.

That's fine, feel free to use jest for this.

rainerhahnekamp commented 8 months ago

https://github.com/timdeschryver/ngrx-immer/pull/24

timdeschryver commented 7 months ago

Closed by #24