search

timdeschryver / zod-fixture

Creating fixtures based on zod schemas
https://zod-fixture.timdeschryver.dev/
MIT License
121 stars 10 forks source link

propertName typo #13

Closed mlamothe closed 1 year ago

mlamothe commented 1 year ago

Hi, nice library!

I just wanted to point out that the type CustomizationRequest has a typo: propertName instead of propertyName.

I can submit a pull request if you'd like, just let me know what version number to use.

Thanks, Marcel

timdeschryver commented 1 year ago

Hey @mlamothe thanks! That's a good catch, but I think it's not worth it to currently address this because this means that it would be a breaking change. We're currently working on a v2 version (see #14), we'll make sure that this typo is fixed in that version.

mlamothe commented 1 year ago

Waiting until v2 makes sense. in the meantime, I've found another typo: randomValueOfPossiblesCustomication instead of randomValueOfPossiblesCustomization (Note that both the variable and the file name have the typo).

Do you plan on adding support for datetime in v2 at some point?

timdeschryver commented 1 year ago

😅 Yikes, thanks for pointing that one out as well. Feel free to create an issue for datetime, this is didn't exist yet when this library was created.

timdeschryver commented 1 year ago

Closing this in favor of v2 (2.0.0-beta.2)