search

timdows / MMM-JsonTable

A module for the MagicMirror project which creates a table filled with a list gathered from a json request.
MIT License
25 stars 31 forks source link

Non-substantive changes per recommendations #95

Closed dathbe closed 5 months ago

dathbe commented 5 months ago

Non-substantive changes as recommended here https://github.com/KristjanESPERANTO/MagicMirror-3rd-Party-Modules/blob/main/result.md#MMM-JsonTable-by-timdows

I have tested this, though I'm not sure my non-dev production installation is using eslint-plugin-json, which is changed to eslint-plugin-jsonc (latest version per the documentation I found) in this PR.

They also recommend creating a "flat" eslint config, which I know nothing about, and changing the primary branch name to main, which I can't do in a PR.

Update: I don't recommend changing the branch name as it will mess with git pull

dathbe commented 5 months ago

I'll close and let you deal with ESLint. Once you have the ESLint tutorial up, I may try to tackle it. But I'm not very good with javascript, so I definitely don't know how to check it with ESLint.

dathbe commented 5 months ago

Reopening with the jsonc change backed out. The others should be fine.