search

timdows / MMM-JsonTable

A module for the MagicMirror project which creates a table filled with a list gathered from a json request.
MIT License
25 stars 31 forks source link

Added colors to the module #97

Closed SirStepheno closed 2 months ago

SirStepheno commented 2 months ago

Made it possible to add options to a value, such as color, by using a dictonary instead of a string for a given value.

It is backwards compatible, because it checks if there is a dictionary instead of a string.

Can be extended on, with more keys in the future.

Coincidentally also mentioned in issue #57

SirStepheno commented 2 months ago

I think removing the comments in the JSON section of the README fixes the test error, but I don't got that one while running "npm run test" on my own environment.

timdows commented 2 months ago

I think removing the comments in the JSON section of the README fixes the test error, but I don't got that one while running "npm run test" on my own environment.

Thanks for the fix, for now lets just leave out the styling issues I'll fix that later and approve this request