search

timduly4 / pyglow

Upper atmosphere climatological models in Python
MIT License
104 stars 57 forks source link

No more Profile? #111

Open aburrell opened 5 years ago

aburrell commented 5 years ago

Profile functionality was removed, was this intentional?

bharding512 commented 5 years ago

I don't think this pull request was ever accepted: https://github.com/timduly4/pyglow/pull/25

timduly4 commented 5 years ago

It is almost trivial to put this back in (e.g.):

class Profile:
    def __init__(self, dn, lat, lon, start_height, end_height, spacing=1):
        altitudes = range(start_height, end_height, spacing)
        self.points = [Point(dn, lat, lon, altitude) for altitude in altitudes)
aburrell commented 5 years ago

It would be nice to have (back) in, since it's how I've continued to use pyglow.

In light of #25 never being accepted, a pull request that stale should probably be closed.

timduly4 commented 5 years ago

We'll keep this as an outstanding issue, then. For better or worse, I'm behind on several pyglow issues at the moment-- these are the perils of an open-source project...