search

time-rs / time

The most used Rust library for date and time handling.
https://time-rs.github.io
Apache License 2.0
1.09k stars 273 forks source link

Use `deserialize_str` for ISO 8601 #531

Closed mati865 closed 1 year ago

mati865 commented 1 year ago

Follow-up to https://github.com/time-rs/time/pull/469 for recently added ISO 8601.

codecov[bot] commented 1 year ago

Codecov Report

Merging #531 (2b085ec) into main (02aa2b8) will not change coverage. The diff coverage is 100.0%.

:exclamation: Current head 2b085ec differs from pull request most recent head cb1ec5f. Consider uploading reports for the commit cb1ec5f to get more accurate results

@@          Coverage Diff          @@
##            main    #531   +/-   ##
=====================================
  Coverage   98.3%   98.3%           
=====================================
  Files         76      76           
  Lines       8275    8275           
=====================================
  Hits        8138    8138           
  Misses       137     137
Impacted Files Coverage Δ
time/src/serde/iso8601.rs 100.0% <100.0%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

jhpratt commented 1 year ago

The diff is fine, but can you change the commit message? It's using deserialize_str and is switching away from deserialize_any.

mati865 commented 1 year ago

Oof, copy-paste error.

jhpratt commented 1 year ago

It happens! Thanks.

mati865 commented 1 year ago

Thanks!