search

time-rs / time

The most used Rust library for date and time handling.
https://time-rs.github.io
Apache License 2.0
1.06k stars 261 forks source link

Force `Time` to be aligned on 8 bytes #599

Closed krtab closed 12 months ago

krtab commented 1 year ago

This is split up and based on #598

Benchmarks will highly depend on the architecture I guess, I'd love to see them run on one where reading an u64 aligned on 4 bytes is costly/impossible but I don't have access to such an architecture at the moment.

codecov[bot] commented 1 year ago

Codecov Report

Merging #599 (30586ad) into main (cbf1349) will decrease coverage by 0.0%. The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main    #599     +/-   ##
=======================================
- Coverage   95.8%   95.8%   -0.0%     
=======================================
  Files         79      79             
  Lines       8927    8899     -28     
=======================================
- Hits        8552    8524     -28     
  Misses       375     375
Impacted Files Coverage Δ
time/src/time.rs 100.0% <100.0%> (ø)

... and 8 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

jhpratt commented 12 months ago

Barring any data that demonstrate a difference, I don't see any reason to merge this given the drawbacks.