chore(lib.rs): renamed no_coverage with coverate_attribute

time-rs / time

The most used Rust library for date and time handling.

https://time-rs.github.io

Apache License 2.0

1.06k stars 261 forks source link

chore(lib.rs): renamed no_coverage with coverate_attribute #620

Closed hitenkoku closed 10 months ago

hitenkoku commented 10 months ago

Closed #619

What Changed

replaced no_coverage with coverage_attribute due to no_coverage

I would appreciate it if you could review when you have time.

codecov[bot] commented 10 months ago

Codecov Report

Merging #620 (7fc5f3d) into main (6aa8db5) will not change coverage. The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #620   +/-   ##
=====================================
  Coverage   98.5%   98.5%           
=====================================
  Files         80      80           
  Lines       9105    9105           
=====================================
  Hits        8968    8968           
  Misses       137     137

Files Changed	Coverage Δ
time/src/lib.rs	`100.0% <ø> (ø)`

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

jhpratt commented 10 months ago

A quick search shows that this isn't even used any more. If you'd like to remove the feature gate outright, that would be even better :slightly_smiling_face:

hitenkoku commented 10 months ago

Thanks for comment. Sorry for the delay in responding. This pull reqesst is closed because this pull request is duplicated #622 .

A quick search shows that this isn't even used any more. If you'd like to remove the feature gate outright, that would be even better 🙂