Closed ogarcia closed 5 months ago
At quick glance this looks correct. My nits are minor at this point: I would split the tests for seconds/milliseconds/etc. into different functions, rather than just keeping it as one. I'd also indicate in the module documentation that it's the Unix timestamp in milliseconds (as appropriate).
Done. I have added your suggestions. In the documentation of each module I have detailed if it is milliseconds/etc. and I have separated the tests into different functions. :smile:
LGTM. Thanks and good work!
As discussed in #647 this merge request adds the ability to serialize and deserialize timestamps with milliseconds, microseconds and nanoseconds.
For now I have only implemented the milliseconds because I want to see if it looks right to you @jhpratt if so then I do the rest.
The idea is that you can do the following: