Fix alignment of `Parsed` test

time-rs / time

The most used Rust library for date and time handling.

https://time-rs.github.io

Apache License 2.0

1.06k stars 261 forks source link

Fix alignment of `Parsed` test #665

Closed GuillaumeGomez closed 4 months ago

GuillaumeGomez commented 4 months ago

This test is failing on latest rust nightly (since https://github.com/rust-lang/rust/pull/116672) and in rustc_codegen_gcc in the sync we're currently doing. Instead of having cfg, simpler to compare with u128 type alignment directly, like that it will work in both nightly and the current version.

GuillaumeGomez commented 4 months ago

As for the CI failing, seems like error messages got updated. Want me to include a commit to fix them?

jhpratt commented 4 months ago

That one CI check has been failing for a little while now due to rust-lang/rust#119273.

Delegating alignment to what it is for i128 is definitely the smart thing to do. Thanks!