search

time-rs / time

The most used Rust library for date and time handling.
https://time-rs.github.io
Apache License 2.0
1.06k stars 261 forks source link

Delete identity conversion in format_description::parse_owned #671

Closed dtolnay closed 3 months ago

dtolnay commented 3 months ago

We have format_items: impl Iterator<Item = Result<Item<'_>, Error>> and items: Box<[Item<'_>]>.

The Into::into on the deleted line is resolving to impl<T> From<T> for T with T=Item which is not load-bearing.

The into on the line after this is impl From<Box<[Item<'_>]>> for OwnedFormatItem.

jhpratt commented 3 months ago

Not sure how I missed this when it was committed. Presumably I used it for debugging at some point. In any situation, thanks!