search

time-rs / time

The most used Rust library for date and time handling.
https://time-rs.github.io
Apache License 2.0
1.13k stars 281 forks source link

Fix sub-second negative Duration serialization. #692

Closed vriesk closed 1 month ago

vriesk commented 4 months ago

This addresses the problem that the Duration's sign will "disappear" both during serialization and deserialization of sub-second Durations.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.7%. Comparing base (4a74924) to head (fa1e57a). Report is 46 commits behind head on main.

:exclamation: Current head fa1e57a differs from pull request most recent head 9a7603f

Please upload reports for the commit 9a7603f to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #692 +/- ## ======================================= - Coverage 97.8% 97.7% -0.1% ======================================= Files 81 83 +2 Lines 9378 8984 -394 ======================================= - Hits 9169 8777 -392 + Misses 209 207 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vriesk commented 2 months ago

PTAL? :)

jhpratt commented 2 months ago

This is still waiting on resolution to the changed comment.

vriesk commented 2 months ago

OK. But I replied there a while ago. I can just remove the comment change from the PR if you still disagree with me.

On Sun, 22 Sep 2024 at 00:47, Jacob Pratt @.***> wrote:

This is still waiting on resolution to the changed comment.

— Reply to this email directly, view it on GitHub https://github.com/time-rs/time/pull/692#issuecomment-2365345758, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABYQ56TNCSZ3CNVFOCYALETZXXZQ5AVCNFSM6AAAAABKPHZQTCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRVGM2DKNZVHA . You are receiving this because you authored the thread.Message ID: @.***>

jhpratt commented 2 months ago

That is what I had initially requested, yes.

vriesk commented 1 month ago

That is what I had initially requested, yes.

Done, PTAL.

jhpratt commented 1 month ago

Sorry, I did not mean to close this! It happened automatically (somehow) when force-pushing a rebase.

Due to a quirk of GitHub, any PR that is force-pushed after being closed cannot be re-opened. As such I'll be merging it manually, so as to avoid making you open a new PR. You're still credited as the author :slightly_smiling_face: