search

time-rs / time

The most used Rust library for date and time handling.
https://time-rs.github.io
Apache License 2.0
1.13k stars 281 forks source link

feat: Change to use `core::error::Error` #706

Closed sorairolake closed 2 months ago

sorairolake commented 2 months ago

Change to use core::error::Error instead of std::error::Error. The MSRV is bumped up to 1.81.0 by this change.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.7%. Comparing base (4a74924) to head (df0491c). Report is 44 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #706 +/- ## ======================================= - Coverage 97.8% 97.7% -0.1% ======================================= Files 81 83 +2 Lines 9378 8974 -404 ======================================= - Hits 9169 8767 -402 + Misses 209 207 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jhpratt commented 2 months ago

This violates the MSRV policy in the README. Additionally, I am very deliberate about bumping MSRV and track a number of features to ensure that I'm not increasing it for only a single thing.

sorairolake commented 2 months ago

I think this will no longer be a violation of the MSRV policy once Rust 1.83 is released. So I think this can be kept as draft pull request.

jhpratt commented 2 months ago

I do not intend to bump the MSRV the moment 1.83 is out. I will batch a number of changes together and do it all at once, not piecemeal. That's not to mention the countless changes made in this PR for unclear reasons.

sorairolake commented 2 months ago

That's not to mention the countless changes made in this PR for unclear reasons.

@jhpratt This is because the CI will not pass unless apply cargo fmt to unchanged files too. This is unrelated to this change, so I separated it out as df0491c.