time-series-machine-learning / tsml-eval

Evaluation tools for time series machine learning algorithms.
https://tsml-eval.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
28 stars 14 forks source link

[SEG] Comments #251

Closed Moonzyyy closed 4 weeks ago

Moonzyyy commented 1 month ago

What does this implement/fix? Explain your changes

Added comments, preparing for tomorrow's meeting.

tsml-actions-bot[bot] commented 1 month ago

Thank you for contributing to tsml-eval

I did not find any labels to add based on the title.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

Moonzyyy commented 1 month ago

Just moved my working folder to _wip and also changed segmentation to series transformer. Had a massive error happening with top down approach which is also now fixed.

MatthewMiddlehurst commented 1 month ago

The old versions seem to be in the package still, you can see both in the diff.

MatthewMiddlehurst commented 1 month ago

Also FYI, tests do not run when PRing into branches other than main currently.

Moonzyyy commented 1 month ago

The old versions seem to be in the package still, you can see both in the diff.

Apologies! Should all be removed now.