time-series-machine-learning / tsml-eval

Evaluation tools for time series machine learning algorithms.
https://tsml-eval.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
28 stars 14 forks source link

[ENH] test and pca fixes for r-clustering #253

Closed chrisholder closed 1 month ago

chrisholder commented 1 month ago

Reference Issues/PRs

This PR fixes a bug where PCA couldnt be used on test/train split and adds basic tests to ensure it works.

What does this implement/fix? Explain your changes

Any other comments?

tsml-actions-bot[bot] commented 1 month ago

Thank you for contributing to tsml-eval

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ]. I have added the following labels to this PR based on the changes made: [ $\color{#F88288}{\textsf{estimators}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.