time4tea / gopro-dashboard-overlay

Programs to process GoPro MP4 & Generic GPX/FIT files and create video dashboards & maps
GNU General Public License v3.0
383 stars 52 forks source link

Attribute Error when Evaluating GoPro and GPX File Overlap #154

Closed IbnGit closed 1 year ago

IbnGit commented 1 year ago

Hi there -

It's been long while, but I've been using your code for quite some time now. We exchanged emails a while back about time lapses.

Anyway, I've updated to the latest code recently and I seem to be getting this error whenever I am using GoPro and GPX data to create overlays. This was not the case in the past. As best as I can tell, my issue is with DateRange.overlap_seconds. Specifically, it's the 2nd time it's called (~line 236) and it's that the function is trying to do something with two different types of variables: frame_meta is Timeunit (I think) while fit_or_gpx_timeseries's is datetime.datetime.

I'm not sure if this is just me, but I can't see any other open or closed issues related to this...so hopefully just a user error??

Thanks!

Screenshot 2023-10-23 at 9 06 03 PM
time4tea commented 1 year ago

Hi there - thanks for reporting this. I'll look into it....

time4tea commented 1 year ago

This should be fixed in 0.108.0 which will be on PyPI in a few moments.

IbnGit commented 1 year ago

Worked for me! Thank you.

time4tea commented 1 year ago

Thank you very much for reporting!