search

timedata-org / old-timedata

Time arts data - high-performance color processing in C++ and Python.
7 stars 3 forks source link

Poor handling/understanding of Cython and C++ strings. #1

Closed rec closed 8 years ago

rec commented 8 years ago

I did get this to work but there's an unnecessary conversion to bytes of something that should already be a char const* just "to make it all compile" - so there's an unnecessary allocation and copy going on.

This is not a big deal - we're going to make pretty small use of strings, and generally we just use them from Python once to construct a Color - but I wanted to note my perplexity here.

rec commented 8 years ago

Think I fixed this. Might reopen later.