timedtext / expo-config-plugin-ios-share-extension

An Expo config plugin to auto-configure iOS Share Extension.
77 stars 12 forks source link

feat: add "activationRules" parameters to the plugin #11

Closed achorein closed 6 months ago

achorein commented 1 year ago

In order to prepare plugin for the next version with "Support receiving more content types", this PR add support to customize "plist" file NSExtensionActivationRule content from app.json

Example

  "plugins": [
     [
       "expo-config-plugin-ios-share-extension", 
       {
          "activationRules": {
             "NSExtensionActivationSupportsText": true
          }
       }
     ]
  ],
timedtext commented 1 year ago

Hi @achorein, appreciate your work. I noticed that there are additional changes in your patch file. Will you be submitting any other pull requests as well? What are your plans going forward?

achorein commented 1 year ago

From my point of view react-native-receive-sharing-intent works just well (especially for ios) and we can take inspiration from his work.

The patch file you mention only inject swift code from "react-native-receive-sharing-intent" in order to keep the same implementation in react native.

So an easy way to get full support of content types :

i can give it a try if you want, but not really in my priorities because I have a working solution for the moment with my demo. It's the expo module for Android that catches my attention the most since the gradle build is no longer functional on react-native-receive-sharing-intent. For the android expo plugin could start with this patch which allow react-native-receive-sharing-intent working well in expo 46.

timedtext commented 1 year ago

We should put it off for now. I've been busy too. If you decide to send a new PR, feel free to do so at your convenience.

achorein commented 1 year ago

Alright, on my side I finally managed to make android work on all versions of expo, with the corresponding demos. keep you in touch for next PR

crieggalder commented 7 months ago

Hi @timedtext - any update here? Appreciate you two teaming up on this

achorein commented 6 months ago

I'm finally working on new npm package which use a native module for android too : https://www.npmjs.com/package/expo-share-intent

@crieggalder still in beta but you can give it a try with expo 50

@timedtext I reused your code and the other PR (#12) as well, let me know if you want access to the new repo ;)

timedtext commented 6 months ago

Great work! @achorein congratulations! Recently, I haven't been using this project. I will consider whether to close this project and recommend using yours, later on.