search

timeglider / jquery_widget

Timeglider's JS Widget component. See README for details.
193 stars 41 forks source link

'focus_date' does not default to date of first event #20

Closed jeremyboggs closed 12 years ago

jeremyboggs commented 13 years ago

The documentation indicates that the default for 'focus_date' is the date of the first event loaded on the timeline. However, when I omit 'focus_date' from the timeline options, the timeline breaks, even though there is an event with a valid 'startdate' fed to the timeline. If I explicitly set a 'focus_date' on the timeline options, the timeline loads correctly.

Curious whether this is a bug in the code, or if there is some other way of setting the 'focus_date' to the first event on the timeline.

timeglider commented 13 years ago

This is what one might call a "bug of omission" ----- as I was writing the documentation, I was picturing what it ought to be rather than what it was. Will update the actual code to reflect this (give me a few days).

Michael

On Mon, Jul 25, 2011 at 2:39 PM, clioweb < reply@reply.github.com>wrote:

The documentation indicates that the default for 'focus_date' is the date of the first event loaded on the timeline. However, when I omit 'focus_date' from the timeline options, the timeline breaks, even though there is an event with a valid 'startdate' fed to the timeline. If I explicitly set a 'focus_date' on the timeline options, the timeline loads correctly.

Curious whether this is a bug in the code, or if there is some other way of setting the 'focus_date' to the first event on the timeline.

Reply to this email directly or view it on GitHub: https://github.com/timeglider/jquery_widget/issues/20

timeglider commented 12 years ago

Okay. that took a while. Finally defaulting timeline with no provided focus date to first event's date.

jeremyboggs commented 12 years ago

Terrific, thanks!