timeglider / jquery_widget

Timeglider's JS Widget component. See README for details.
193 stars 41 forks source link

Images and json problem #7

Closed talamaska closed 13 years ago

talamaska commented 13 years ago

first, i'm trying the functionality with html table, the date is working ok. I put a th class="tg-image_url" to put an image in the fancy-box, not in the timeglider, but it seems not working, if i put the param th class="tg-image" it is showing the image in timeglider and in the fancybox i tried also to work with json, but it keeps saying json not valid validate with jsonLint, and i did, and it was valid, first tough it's the escaping of the php json_encode function, tryied to strip slashes, but it's the same result - invalid json. please take a look. here is the json that i generate with php http://jsfiddle.net/goldy/6EcJq/

by looking in TG_timelineview, i feel very confused, that you're taking the image not image_url to display it in fancybox. actually i didn't find anywhere where you're using image_url and it is used in examples. i don't want to have an image on the timeline glider only in fancybox.

talamaska commented 13 years ago

OK I think i have fixed the json problem, strange for me. in php i'm starting like this $data = array( "id"=> "jshist", "title"=> "Humanline", "focus_date"=> "0001-01-01 12:00:00", "initial_zoom"=> "80", "events" => ""); for($i = 0; $i < $items_num ; $i++){ $temp = array( event data ); $data["events"][] = $temp; } echo json_encode($data);

but it was not valid even if I can debug log and see the objects, instead after looking at your json test i saw that the json object is wraped in [], so i do json_encode(array($data)); which return the json in the awaited format i thing it's a problem of getJSON. the problem with a missing image in event description still persist, when i put image_url = "/images/test.png"

and for what are "low_threshold": "1", "high_threshold": "100", "ypix": "0"

timeglider commented 13 years ago

Hi there

I'll try to address your issues in the next couple days. Thanks for your patience!

The image parameter needs to be "image" rather than "image_url" ---- I'll add this (with its options) into the JSON docs.

Michael

On Sat, May 14, 2011 at 4:45 AM, talamaska < reply@reply.github.com>wrote:

first, i'm trying the functionality with html table, the date is working ok. I put a image to put an image in the fancy-box, not in the timeglider, but it seems not working, if i put the param image it is showing the image in timeglider and in the fancybox i tried also to work with json, but it keeps saying json not valid validate with jsonLint, and i did, and it was valid, first tough it's the escaping of the php json_encode function, tryied to strip slashes, but it's the same result - invalid json. please take a look.

Reply to this email directly or view it on GitHub: https://github.com/timeglider/jquery_widget/issues/7

talamaska commented 13 years ago

so if you have removed image_url from options, you should make different way to control the image in the timeglider. as i said before i don't want it, i just used your examples, can you update them too, when you remove some options from the code?