search

timehop / apns

A Go package to interface with the Apple Push Notification Service
https://godoc.org/github.com/timehop/apns
MIT License
185 stars 47 forks source link

Add category field to APS struct #11

Closed awly closed 9 years ago

awly commented 9 years ago

According to http://devstreaming.apple.com/videos/wwdc/2014/713xx1il4h4ur9c/713/713_whats_new_in_ios_notifications.pdf?dl=1 (slides 65+) iOS 8 adds support for new category field in aps object. This PR adds the new field to corresponding struct.

nathany commented 9 years ago

Cool. I suspect they will want some specs, as with #9.

bdotdub commented 9 years ago

Indeed. I'll take a look at #12 - if anyone else can help out that'd be great. I suspect the way we're testing might need to be revamped - creating and tearing down a tcp server is brittle.

awly commented 9 years ago

Sorry, but I would not like to be involved with the way you do testing. I'll leave it up to you to decide what to do with this change and test coverage for it.

bdotdub commented 9 years ago

Not sure what you mean by that, but this seems innocuous enough

nathany commented 9 years ago

Slide 64 mentions category of "Invite" "New mail" or "Tagged". I'm not seeing much in the documentation about this yet.

awly commented 9 years ago

Categories are defined by the app, not APNs. Slide 64 simply shows an example of what they might look like.

nathany commented 9 years ago

Is it working for you? I haven't added a test for this as of yet.

awly commented 9 years ago

Yep, tested this with a few devices, works as expected.