Failing client_test - a little help?

timehop / apns

A Go package to interface with the Apple Push Notification Service

https://godoc.org/github.com/timehop/apns

MIT License

185 stars 47 forks source link

Failing client_test - a little help? #12

Closed nathany closed 9 years ago

nathany commented 9 years ago

@bdotdub So far I haven't been able to figure out why the two tests on Travis CI are failing. They are both tests that have a bad push.

client_test.go:

bad push
good, bad, good, requeue of last good

https://travis-ci.org/timehop/apns

I added some logging into RunLoop where the 1 second sleep is. As it turns out, neither of these tests hit that (several other tests did log errors here, probably intentionally - invalid cert, etc).

bdotdub commented 9 years ago

Been trying to figure this one out as well. It's very inconsistent as you've seen.

Ultimately, the way I've written the tests the first time feel super brittle (actually spinning up tls servers for the Client tests.

Would it be too much of a cop out to say this will be fixed via #31 (#33)?

nathany commented 9 years ago

I'm happy with that. :smile:

bdotdub commented 9 years ago

Sweet :)

Closing