Open nathany opened 9 years ago
Gross. I expect this to get cleared up with #17 (synchronous Send
, no requeueing?), but it's good to keep an eye on it.
I'd be happy just to remove the "set an identifier if not set" logic and always require it from the caller.
I still think removing determineIdentifier
entirely would be the best bet. Just require the identifier from the client.
I do like the idea of "transparent defaults", but I do see your point as well. I wouldn't be heartbroken either way. :wink:
When replaying notifications, should it use the same IDs or call determineIdentifier for new ones?
This relates to #10, as I try to build a synchronous API around Send and FailedNotif.
To get an error from Apple, I am changing a single digit in an otherwise valid device token. I've added logging to timehop/apns.
On this push (with invalid data) nothing comes back from Apple:
That's not great, but okay. On this push, errrors are coming back from Apple, but the identifiers don't match up so FailedNotifs are never sent.
If Identifier is set, then I do see an identifier match and the error is sent via FailedNotif: