Closed nathany closed 8 years ago
:+1:
Before the PR from @themartorana, go-libapns was just using -1 to reset the badge rather than 0 (which is omitted, meaning no change).
anachronistic/apns uses an interface for different types of Alerts. That could be another option for the badge.
The biggest issue I had with -1 is that the struct is initialized with 0, a valid (and badge-clearing) value. So unless you hide the struct but give it a public initializer method, its default state is to clear the badge.
Ping on this - looks like we're still using a pointer. I can quickly submit a NullInt64-esque solution like https://github.com/joekarl/go-libapns/pull/8 (my preferred method). Thoughts?
Go for it!
On Thu, Sep 3, 2015 at 12:32 PM, David Martorana notifications@github.com wrote:
Ping on this - looks like we're still using a pointer. I can quickly submit a NullInt64-esque solution like https://github.com/joekarl/go-libapns/pull/8 (my preferred method). Thoughts?
Reply to this email directly or view it on GitHub: https://github.com/timehop/apns/issues/38#issuecomment-137550321
closed with #60