document exported identifiers

timehop / apns

A Go package to interface with the Apple Push Notification Service

https://godoc.org/github.com/timehop/apns

MIT License

185 stars 47 forks source link

Closed nathany closed 9 years ago

nathany commented 9 years ago

and lint fixes

nathany commented 9 years ago

I think it may be exporting more API than necessary (eg. NewError).

taylortrimble commented 9 years ago

@nathany did you address your comments before merging?

nathany commented 9 years ago

No, I didn't. :-(

Does it make sense to have an error type inside a custom Error struct that also contains an Identifier?